Skip to content

PostgreSQL - sql error save category with tag#6326

Closed
alikon wants to merge 3 commits intojoomla:stagingfrom
alikon:patch-9
Closed

PostgreSQL - sql error save category with tag#6326
alikon wants to merge 3 commits intojoomla:stagingfrom
alikon:patch-9

Conversation

@alikon
Copy link
Copy Markdown
Contributor

@alikon alikon commented Mar 5, 2015

Steps to reproduce the issue

go to the category manager and create or edit a category In the tags field create or add a tag then click "Save".

Expected result

The category is saved with the tag

Actual result

the tag field is cleared and the category is not saved

System information

PostgreSQL 9.3.5
Joomla 3.4.0

Additional comments

added a sanity check for NOT NULL FIELDS

@alikon
PostgreSQL - sql error save category with tag
d87c6aa 
#### Steps to reproduce the issue
go to the category manager and create or edit a category  In the tags field create or add a tag then click  "Save".

#### Expected result
The category is saved with the  tag

#### Actual result 
the tag field is cleared and the category is not saved

#### System information
PostgreSQL 9.3.5
Joomla 3.4.0

#### Additional comments
added a sanity check for NOT NULL FIELDS
@waader
Copy link
Copy Markdown
Contributor

waader commented Mar 5, 2015

@alikon Please try the following test cases:

  • Add a new (=ad hoc) tag to an existing or new category and save. That works.
  • Repeat the above step: You get the following error: SQL=INSERT INTO sdfjk_contentitem_tag_map

mssql gives this error message:
23000 [Microsoft][SQL Server Native Client 11.0][SQL Server]Cannot insert the value NULL into column 'core_xreference', table 'joomla34.dbo.ufv5y_ucm_content'; column does not allow nulls. INSERT fails.SQL=INSERT INTO ufv5y_ucm_content VALUES ('com_content.category','Joomla!','joomla','','1','1','{"category_layout":"","image":"","image_alt":""}','{"author":"","robots":""}','247','2011-01-01 00:00:00.000','2015-03-05 20:26:38','*','19','{}','{}','0','1','','','14','5')

alikon added 2 commits March 5, 2015 23:10
@alikon
travis error
1f5e40f 
tabs instead of spaces
@alikon
whitespace
7e518ea 
whitespace  removed
@alikon
Copy link
Copy Markdown
Contributor Author

alikon commented Mar 6, 2015

retest with #6314

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented May 23, 2015

Issue confirmed
Tested with this PR an #6314
Issue resolved

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6326.

@waader
Copy link
Copy Markdown
Contributor

waader commented Jun 26, 2015

@test works fine! Thanks!

@zero-24
Copy link
Copy Markdown
Contributor

zero-24 commented Jun 26, 2015

RTC based on testing 😄

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6326.

@zero-24 zero-24 added the RTC This Pull Request is Ready To Commit label Jun 26, 2015
@zero-24 zero-24 modified the milestone: Joomla! 3.4.4 Jul 2, 2015
@Kubik-Rubik
Copy link
Copy Markdown
Member

Kubik-Rubik commented Jul 9, 2015

Thank you @alikon! Merged.

@zero-24 zero-24 removed the RTC This Pull Request is Ready To Commit label Oct 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Joomla! 3.4.4

Development

Successfully merging this pull request may close these issues.

6 participants

@alikon @waader @brianteeman @zero-24 @Kubik-Rubik @joomla-cms-bot